http://codereview.chromium.org/569015/diff/3008/20 File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/20#newcode56 src/arm/assembler-arm.cc:56: supported_ |= 1u << VFP3; Please add a comment on why ARMv7 is enabled when running the simulator. Also please add an enable_armv7 flag (flag-definitions.h). Also I think we should take the flags FLAG_enable_vfp3 and FLAG_enable_armv7 into account when running the simulator. http://codereview.chromium.org/569015/diff/3008/19 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/569015/diff/3008/19#newcode6018 src/arm/codegen-arm.cc:6018: // Remove tags from right operand. Consider refactoring to avoid duplicated code. http://codereview.chromium.org/569015/diff/3008/19#newcode6020 src/arm/codegen-arm.cc:6020: // UBFX r2, r0, #kSmiTagSize, #(5-1) This comment is not needed (two more below). http://codereview.chromium.org/569015/diff/3008/19#newcode6024 src/arm/codegen-arm.cc:6024: // Use only the 5 least significant bits of the shift count. Please hoist this comment to above "if (CpuFeatures::IsSupported(ARMv7))..." (two more below). http://codereview.chromium.org/569015/diff/3008/21 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/569015/diff/3008/21#newcode1771 src/arm/simulator-arm.cc:1771: if ((instr->HasW()) && (instr->HasW()) && (instr->Bits(6, 4) == 0x5)) { Please only use C++ style casts. http://codereview.chromium.org/569015 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
