I like it a lot, it is way simpler now! Looking almost good. A few comments
left.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces-inl.h#newcode358
src/heap/spaces-inl.h:358: top = allocation_info_.top();
We got a new top here, we have to recalculate
filler_size = Heap::GetFillToAlign(top, alignment);
and
aligned_size_in_bytes = size_in_bytes + filler_size;
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces.cc#newcode1474
src/heap/spaces.cc:1474: if (old_top + size_in_bytes >= high) {
We should compare against aligned_size_in_bytes here. We can pass it in,
or recalculate in the beginning.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces.cc#newcode1484
src/heap/spaces.cc:1484: top_on_previous_step_ = to_space_.page_low();
to_space_.page_low() should be the same as allocation_info_.top() in
this case. Just set top_on_previous_step_ = old_top after setting
old_top.
https://codereview.chromium.org/1265443003/diff/20001/src/heap/spaces.cc#newcode1486
src/heap/spaces.cc:1486: old_top = allocation_info_.top();
Since we got a new top here, we have to recalculate
aligned_size_in_bytes.
https://codereview.chromium.org/1265443003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
