Just one comment, and Andreas should generally agree that it's a sane idea :)

LGTM.



https://codereview.chromium.org/1260053004/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1260053004/diff/1/src/parser.cc#newcode4446
src/parser.cc:4446: result->Set(0, factory()->NewExpressionStatement(
Could you define this reserved spot as a constant index at line 4328,
like:
const int functionNameStatementIndex = 0;

and use that in the Set() statement instead of 0.

https://codereview.chromium.org/1260053004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to