Reviewers: Hannes Payer,
Message:
ptal
Description:
Partially revert 5aacee to see its impact on memory histograms.
Original CL: https://crrev.com/5aaceefd9a84327ce6afeaea16557449bf83ce57
BUG=chromium:515721
LOG=NO
Please review this at https://codereview.chromium.org/1264063003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+10, -0 lines):
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
49c327be29557ee33e59bc040ba6ea61bdd4bab7..05e2d0e0b89812515cb607f215c3fff3c3f591e3
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4950,6 +4950,16 @@ void Heap::IdleNotificationEpilogue(GCIdleTimeAction
action,
isolate()->counters()->gc_idle_time_allotted_in_ms()->AddSample(
static_cast<int>(idle_time_in_ms));
+ if (deadline_in_ms - start_ms >
+ GCIdleTimeHandler::kMaxFrameRenderingIdleTime) {
+ int committed_memory = static_cast<int>(CommittedMemory() / KB);
+ int used_memory = static_cast<int>(heap_state.size_of_objects / KB);
+ isolate()->counters()->aggregated_memory_heap_committed()->AddSample(
+ start_ms, committed_memory);
+ isolate()->counters()->aggregated_memory_heap_used()->AddSample(
+ start_ms, used_memory);
+ }
+
if (deadline_difference >= 0) {
if (action.type != DONE && action.type != DO_NOTHING) {
isolate()->counters()->gc_idle_time_limit_undershot()->AddSample(
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
