LGTM one nit. :)
https://codereview.chromium.org/1266013006/diff/1/src/ia32/interface-descriptors-ia32.cc
File src/ia32/interface-descriptors-ia32.cc (right):
https://codereview.chromium.org/1266013006/diff/1/src/ia32/interface-descriptors-ia32.cc#newcode109
src/ia32/interface-descriptors-ia32.cc:109: Register registers[] =
{eax};
You could also reduce the number of platform dependent lines by defining
ToObjectDescriptor::ReceiverRegister() { return eax; }
in this file, and then InitializePlatformSpecific() over in
interface-descriptors.cc.
https://codereview.chromium.org/1266013006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
