http://codereview.chromium.org/565007/diff/4002/3002
File include/v8-debug.h (right):

http://codereview.chromium.org/565007/diff/4002/3002#newcode274
include/v8-debug.h:274: v8::Local<v8::String>* file_name,
nit: bad arguments alignment

http://codereview.chromium.org/565007/diff/4002/3003
File src/api.cc (right):

http://codereview.chromium.org/565007/diff/4002/3003#newcode3611
src/api.cc:3611: void
Debug::GetFunctionLocation(v8::Handle<v8::Function> func,
I think you should make this function returning boolean, so testing
whether retrieval was successful will become more explicit.

http://codereview.chromium.org/565007

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to