I already fixed this, in version 3778. Sorry. On Wed, Feb 3, 2010 at 11:50 AM, <[email protected]> wrote:
> Reviewers: William Hesse, > > > http://codereview.chromium.org/570002/diff/1/2 > File src/codegen.cc (right): > > http://codereview.chromium.org/570002/diff/1/2#newcode485 > src/codegen.cc:485: const bool indirect_result = result_size_ > 1; > On 2010/02/03 06:18:35, William Hesse wrote: > >> This seems really wrong. Either make the type (int) explicit, or make >> > this a > >> constant bool. >> > > It supposed to be bool. Fixed. > > http://codereview.chromium.org/570002/diff/1/2#newcode491 > src/codegen.cc:491: | IndirectResultBits::encode(indirect_result); > On 2010/02/03 06:18:35, William Hesse wrote: > >> Shouldn't this just be indirect_result, not indirect_result > 1? The >> > second > >> expression is never true. >> > > Sure, it must. > > In all cases except _WIN64, this is encoding 0, which probably doesn't >> > affect > >> the bitwise or, so maybe the entire return statement should be in an >> > #ifdef, and > >> be optimized in all cases except WIN64 to just return >> ExitFrameModeBits::encode(mode). >> > > I don't think such a manual optimization would make sense since it's a > clear case for the C++ optimizer. > > > > Please review this at http://codereview.chromium.org/570002 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/codegen.cc > > > Index: src/codegen.cc > =================================================================== > --- src/codegen.cc (revision 3775) > +++ src/codegen.cc (working copy) > @@ -482,13 +482,13 @@ > int CEntryStub::MinorKey() { > ASSERT(result_size_ <= 2); > #ifdef _WIN64 > - const indirect_result = result_size_ > 1; > + const bool indirect_result = result_size_ > 1; > #else > const bool indirect_result = false; > #endif > > return ExitFrameModeBits::encode(mode_) > - | IndirectResultBits::encode(indirect_result > 1); > + | IndirectResultBits::encode(indirect_result); > } > > > > > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
