Nice fix! LGTM, modulo the two typos. I will fix these and land this now.
https://codereview.chromium.org/1216823003/diff/60001/src/mips64/assembler-mips64.cc
File src/mips64/assembler-mips64.cc (right):
https://codereview.chromium.org/1216823003/diff/60001/src/mips64/assembler-mips64.cc#newcode1455
src/mips64/assembler-mips64.cc:1455: j(imm);
typo: this should be jal()
https://codereview.chromium.org/1216823003/diff/60001/src/mips64/macro-assembler-mips64.cc
File src/mips64/macro-assembler-mips64.cc (right):
https://codereview.chromium.org/1216823003/diff/60001/src/mips64/macro-assembler-mips64.cc#newcode2758
src/mips64/macro-assembler-mips64.cc:2758: J(L, bdslot);
This should be Jal(L, bdslot), was incorrect from 962703cac
(https://codereview.chromium.org/1147503002)
https://codereview.chromium.org/1216823003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
