LGTM with nits.
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode396
src/gdb-jit.cc:396:
nit: why this change?
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode678
src/gdb-jit.cc:678: // Join the next 4 lines, omitting the spaces and
double-slashes.
Links are exempt from the 80-col policy; however this one is very long
indeed, and sticking wtih 80-col is nice. How about a goo.gl shortcut?
Or you can leave it as is, I'm fine with either.
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode700
src/gdb-jit.cc:700:
nit: why this change?
https://codereview.chromium.org/1252913007/diff/1/src/gdb-jit.cc#newcode1149
src/gdb-jit.cc:1149: w->Write<uint8_t>(DW_OP_reg31); // The frame
pointer is here on PPC64
nit: trailing full stop please.
https://codereview.chromium.org/1252913007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
