On 2015/08/03 15:59:09, Michael Starzinger wrote:
LGTM with one optional suggestion.
https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1259193004/diff/1/src/interpreter/bytecodes.h#newcode104
src/interpreter/bytecodes.h:104: const uint8_t* bytecode_end);
It looks like the {bytecode_end} argument is only used for checking, and
we
could do without it. I am fine with leaving it as it is if you think the
interface makes more sense that way. Up to you.
Thanks Michael. Pruned this, it was redundant and not telling us anything
useful.
https://codereview.chromium.org/1259193004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
