[v8-dev] MIPS: Fix reg use in SIMD.js Add the other SIMD Phase 1 types. (issue 1264103005 by [email protected])

Mon, 03 Aug 2015 20:58:51 -0700 

Reviewers: bbudge, akos.palfi.imgtec, balazs.kilvady,

Message:
PTAL.

Description:
MIPS: Fix reg use in SIMD.js Add the other SIMD Phase 1 types.

Port 7b9670b63b486ba3b6f8a569552d307282dbccfd

Only fails in debug builds.

TEST=mjsunit/harmony/simd
BUG=

Please review this at https://codereview.chromium.org/1264103005/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+2, -2 lines):
  M src/mips/lithium-codegen-mips.cc
  M src/mips64/lithium-codegen-mips64.cc


Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc index 88adcd421769ccd5f448e5ba7ee66abd8f928e90..37fa97d2ecc81e3dbf5bd9949ac4aef27073cea4 100644 
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -2186,7 +2186,7 @@ void LCodeGen::DoBranch(LBranch* instr) {
         Label not_simd;
         const Register scratch = scratch1();
         __ lbu(scratch, FieldMemOperand(map, Map::kInstanceTypeOffset));
-        __ Branch(&not_simd, lt, at, Operand(FIRST_SIMD_VALUE_TYPE));
+        __ Branch(&not_simd, lt, scratch, Operand(FIRST_SIMD_VALUE_TYPE));
         __ Branch(instr->TrueLabel(chunk_), le, scratch,
                   Operand(LAST_SIMD_VALUE_TYPE));
         __ bind(&not_simd);
Index: src/mips64/lithium-codegen-mips64.cc
diff --git a/src/mips64/lithium-codegen-mips64.cc b/src/mips64/lithium-codegen-mips64.cc index fe8ee01eeef3962b4da293c22960615f8cf741ba..b676fad4da89b4671aece620ff6d210c04781ec8 100644 
--- a/src/mips64/lithium-codegen-mips64.cc
+++ b/src/mips64/lithium-codegen-mips64.cc
@@ -2287,7 +2287,7 @@ void LCodeGen::DoBranch(LBranch* instr) {
         Label not_simd;
         const Register scratch = scratch1();
         __ lbu(scratch, FieldMemOperand(map, Map::kInstanceTypeOffset));
-        __ Branch(&not_simd, lt, at, Operand(FIRST_SIMD_VALUE_TYPE));
+        __ Branch(&not_simd, lt, scratch, Operand(FIRST_SIMD_VALUE_TYPE));
         __ Branch(instr->TrueLabel(chunk_), le, scratch,
                   Operand(LAST_SIMD_VALUE_TYPE));
         __ bind(&not_simd);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to