On 2015/08/04 12:38:30, Jarin wrote:
lgtm


https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):


https://codereview.chromium.org/1269183002/diff/1/src/compiler/instruction-selector.cc#newcode1004
src/compiler/instruction-selector.cc:1004: Emit(kArchRet, g.NoOutput(),
g.Use(value));
Any reason for calling g.Use(value)? This might keep that value alive for
longer
than it needs to be.

Fixed.

https://codereview.chromium.org/1269183002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to