On 2015/08/03 14:31:31, bbudge wrote:
On 2015/08/03 14:10:34, titzer wrote:
> On 2015/08/03 13:54:42, Yang wrote:
> > On 2015/08/03 13:03:06, commit-bot: I haz the power wrote:
> > > Patchset 11 (id:??) landed as
> > > https://crrev.com/7b9670b63b486ba3b6f8a569552d307282dbccfd
> > > Cr-Commit-Position: refs/heads/master@{#29974}
> >
> > Well by simply marking NOPRESUBMIT=true, other test bots in the CQ
complain
> > about the same issue
> >
>
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4638/steps/presubmit/logs/stdio
>
> Yes, please make sure the CQ runs all of the trybots, including
v8-presubmit.
>
> This CL changed a lot of compiler code in both Crankshaft and fullcode;
it's
> normal to loop in a compiler team person or two for the review in such
cases.
Thanks for the fix Ben. Sorry for any trouble this may have caused. I
would
definitely appreciate a compiler person reviewing the change. If you
prefer,
we
can revert this and review it properly.
No point in reverting, I think -- you can address comments in a follow-up
CLs.
But in general, when you change hundreds of lines of code after an LGTM,
it's
better to wait for another round of review before landing. ;)
Added Ben as an additional reviewer for the compiler-related changes in
this CL.
https://codereview.chromium.org/1250733005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
