Reviewers: Hannes Payer,
Message:
ptal
Description:
Revert d5419b for regressing v8.top_25_smooth benchmark.
BUG=chromium:516425
LOG=NO
Please review this at https://codereview.chromium.org/1271973002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -9 lines):
M src/heap/heap.h
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
6a4acda903ed8cb6e7a95288b041f79197114b81..cd8b528f4226baa7ae678fa1850e2461f931b5fd
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -1273,8 +1273,7 @@ bool Heap::PerformGarbageCollection(
// Register the amount of external allocated memory.
amount_of_external_allocated_memory_at_last_global_gc_ =
amount_of_external_allocated_memory_;
- SetOldGenerationAllocationLimit(old_gen_size, gc_speed, mutator_speed,
- freed_global_handles);
+ SetOldGenerationAllocationLimit(old_gen_size, gc_speed, mutator_speed);
} else if (HasLowYoungGenerationAllocationRate() &&
old_generation_size_configured_) {
DampenOldGenerationAllocationLimit(old_gen_size, gc_speed,
mutator_speed);
@@ -5582,9 +5581,7 @@ intptr_t
Heap::CalculateOldGenerationAllocationLimit(double factor,
void Heap::SetOldGenerationAllocationLimit(intptr_t old_gen_size,
double gc_speed,
- double mutator_speed,
- int freed_global_handles) {
- const int kFreedGlobalHandlesThreshold = 700;
+ double mutator_speed) {
const double kConservativeHeapGrowingFactor = 1.3;
double factor = HeapGrowingFactor(gc_speed, mutator_speed);
@@ -5604,8 +5601,7 @@ void Heap::SetOldGenerationAllocationLimit(intptr_t
old_gen_size,
factor = Min(factor, kMaxHeapGrowingFactorMemoryConstrained);
}
- if (freed_global_handles >= kFreedGlobalHandlesThreshold ||
- memory_reducer_.ShouldGrowHeapSlowly() ||
optimize_for_memory_usage_) {
+ if (memory_reducer_.ShouldGrowHeapSlowly() ||
optimize_for_memory_usage_) {
factor = Min(factor, kConservativeHeapGrowingFactor);
}
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index
750827968dcd757edff47ece2ed0948930aa688f..78c55b62d7f8d4789aacafc33847c704e7b5ecd5
100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -1202,8 +1202,7 @@ class Heap {
// Sets the allocation limit to trigger the next full garbage collection.
void SetOldGenerationAllocationLimit(intptr_t old_gen_size, double
gc_speed,
- double mutator_speed,
- int freed_global_handles);
+ double mutator_speed);
// Decrease the allocation limit if the new limit based on the given
// parameters is lower than the current limit.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
