[v8-dev] Rename IsSimdObject assembly intrinsic. (issue 1253103006 by [email protected])

Tue, 04 Aug 2015 07:13:15 -0700 

Reviewers: rossberg,

Description:
Rename IsSimdObject assembly intrinsic.
Change IS_SIMD_OBJECT to IS_SIMD_VALUE, and IsSimdObject to IsSimdValue.

R=rossberg
LOG=N
BUG=v8:4124

Please review this at https://codereview.chromium.org/1253103006/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+23, -23 lines):
  M src/full-codegen/arm/full-codegen-arm.cc
  M src/full-codegen/arm64/full-codegen-arm64.cc
  M src/full-codegen/full-codegen.h
  M src/full-codegen/ia32/full-codegen-ia32.cc
  M src/full-codegen/mips/full-codegen-mips.cc
  M src/full-codegen/mips64/full-codegen-mips64.cc
  M src/full-codegen/ppc/full-codegen-ppc.cc
  M src/full-codegen/x64/full-codegen-x64.cc
  M src/full-codegen/x87/full-codegen-x87.cc
  M src/macros.py
  M src/messages.js
  M src/runtime.js
  M src/runtime/runtime.h
  M src/runtime/runtime-simd.cc


Index: src/full-codegen/arm/full-codegen-arm.cc
diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc index e0bd5e93565c4139feb909f0665749ec22fc68bd..4d9e794396d78ecc965a6fc0c10d9418cd2bb8a9 100644 
--- a/src/full-codegen/arm/full-codegen-arm.cc
+++ b/src/full-codegen/arm/full-codegen-arm.cc
@@ -3431,7 +3431,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/arm64/full-codegen-arm64.cc
diff --git a/src/full-codegen/arm64/full-codegen-arm64.cc b/src/full-codegen/arm64/full-codegen-arm64.cc index c8ef7d689941d1f20dd7e0c107efa2e3b3991207..655790a10b3d4675f961f084ea9c82373f20e78a 100644 
--- a/src/full-codegen/arm64/full-codegen-arm64.cc
+++ b/src/full-codegen/arm64/full-codegen-arm64.cc
@@ -3121,7 +3121,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/full-codegen.h
diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h index 5d530196f9d2f8a404ed2bb6d6204df527c53389..6761bda27192f84fc25199a5ab5c010449d5dda0 100644 
--- a/src/full-codegen/full-codegen.h
+++ b/src/full-codegen/full-codegen.h
@@ -513,7 +513,7 @@ class FullCodeGenerator: public AstVisitor {
   F(IsFunction)                           \
   F(IsUndetectableObject)                 \
   F(IsSpecObject)                         \
-  F(IsSimdObject)                         \
+  F(IsSimdValue)                          \
   F(IsStringWrapperSafeForDefaultValueOf) \
   F(MathPow)                              \
   F(IsMinusZero)                          \
Index: src/full-codegen/ia32/full-codegen-ia32.cc
diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc index 749e83ec92d096d38cfb03493f1e8ddd6809855a..80fb965d2c71ff00dd42d1e018a15979ebce537b 100644 
--- a/src/full-codegen/ia32/full-codegen-ia32.cc
+++ b/src/full-codegen/ia32/full-codegen-ia32.cc
@@ -3322,7 +3322,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/mips/full-codegen-mips.cc
diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc index 4fa18d5aaa7aa17707d4a5f957af8683dbded407..977a71dbbfec54d5fa1f818005b3fec216a2de04 100644 
--- a/src/full-codegen/mips/full-codegen-mips.cc
+++ b/src/full-codegen/mips/full-codegen-mips.cc
@@ -3421,7 +3421,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/mips64/full-codegen-mips64.cc
diff --git a/src/full-codegen/mips64/full-codegen-mips64.cc b/src/full-codegen/mips64/full-codegen-mips64.cc index 6c43654d443e3f3bba759c0ee5dfc25614ef74b5..6014347fc783ee6c021eaa065b510cb43942b666 100644 
--- a/src/full-codegen/mips64/full-codegen-mips64.cc
+++ b/src/full-codegen/mips64/full-codegen-mips64.cc
@@ -3422,7 +3422,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/ppc/full-codegen-ppc.cc
diff --git a/src/full-codegen/ppc/full-codegen-ppc.cc b/src/full-codegen/ppc/full-codegen-ppc.cc index 35cb05124f38190493da2bcdaa7a9ac8e53b4c21..6ddf6c6a02c8fa42293c5ec239a824346c515b65 100644 
--- a/src/full-codegen/ppc/full-codegen-ppc.cc
+++ b/src/full-codegen/ppc/full-codegen-ppc.cc
@@ -3423,7 +3423,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/x64/full-codegen-x64.cc
diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc index 34d614aedae7ccf546a16e7b1deace5de8204b5a..1eae31d522ea141075511c57b331f8ce85669629 100644 
--- a/src/full-codegen/x64/full-codegen-x64.cc
+++ b/src/full-codegen/x64/full-codegen-x64.cc
@@ -3315,7 +3315,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/full-codegen/x87/full-codegen-x87.cc
diff --git a/src/full-codegen/x87/full-codegen-x87.cc b/src/full-codegen/x87/full-codegen-x87.cc index 177914cd4aa76b4d8d89d240ba113eea444c764c..12d24c0e859c8d54ddaa86a5e24b7d015f3122e1 100644 
--- a/src/full-codegen/x87/full-codegen-x87.cc
+++ b/src/full-codegen/x87/full-codegen-x87.cc
@@ -3313,7 +3313,7 @@ void FullCodeGenerator::EmitIsSpecObject(CallRuntime* expr) { 
 }


-void FullCodeGenerator::EmitIsSimdObject(CallRuntime* expr) {
+void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
   ZoneList<Expression*>* args = expr->arguments();
   DCHECK(args->length() == 1);

Index: src/macros.py
diff --git a/src/macros.py b/src/macros.py
index 757d59fc48b1a0ec77290c470743433e52c9089f..97a1fa8f38b6334b04ac66b45897f36a5d8a1728 100644 
--- a/src/macros.py
+++ b/src/macros.py
@@ -98,7 +98,7 @@ macro IS_ARRAY(arg)             = (%_IsArray(arg));
 macro IS_DATE(arg)              = (%_IsDate(arg));
 macro IS_FUNCTION(arg)          = (%_IsFunction(arg));
 macro IS_REGEXP(arg)            = (%_IsRegExp(arg));
-macro IS_SIMD_OBJECT(arg)       = (%_IsSimdObject(arg));
+macro IS_SIMD_VALUE(arg)        = (%_IsSimdValue(arg));
 macro IS_SET(arg)               = (%_ClassOf(arg) === 'Set');
 macro IS_MAP(arg)               = (%_ClassOf(arg) === 'Map');
 macro IS_WEAKMAP(arg)           = (%_ClassOf(arg) === 'WeakMap');
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index 2101f79b990dbad7e1c6e47472e8571537b77a85..29fa97873c929d1ff14a80130ffbeef814377b9c 100644 
--- a/src/messages.js
+++ b/src/messages.js
@@ -86,7 +86,7 @@ function NoSideEffectToString(obj) {
     return str;
   }
   if (IS_SYMBOL(obj)) return %_CallFunction(obj, $symbolToString);
-  if (IS_SIMD_OBJECT(obj)) {
+  if (IS_SIMD_VALUE(obj)) {
     switch (typeof(obj)) {
       case 'float32x4': return %_CallFunction(obj, $float32x4ToString);
       case 'int32x4':   return %_CallFunction(obj, $int32x4ToString);
Index: src/runtime.js
diff --git a/src/runtime.js b/src/runtime.js
index b4bec8ae89529c473db6ab0b89631d0302064c89..5e37e26c3c9d7df7bcf802c01bfe0fbc04633c34 100644 
--- a/src/runtime.js
+++ b/src/runtime.js
@@ -102,7 +102,7 @@ EQUALS = function EQUALS(y) {
         if (IS_NUMBER(y)) return %NumberEquals(x, y);
         if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
         if (!IS_SPEC_OBJECT(y)) {
-          if (IS_SYMBOL(y) || IS_SIMD_OBJECT(y)) return 1;  // not equal
+          if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal
           // String or boolean.
           return %NumberEquals(x, %$toNumber(y));
         }
@@ -114,7 +114,7 @@ EQUALS = function EQUALS(y) {
         if (IS_NUMBER(y)) return %NumberEquals(%$toNumber(x), y);
if (IS_BOOLEAN(y)) return %NumberEquals(%$toNumber(x), %$toNumber(y)); 
         if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
-        if (IS_SYMBOL(y) || IS_SIMD_OBJECT(y)) return 1;  // not equal
+        if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal
         y = %$toPrimitive(y, NO_HINT);
       }
     } else if (IS_SYMBOL(x)) {
@@ -125,13 +125,13 @@ EQUALS = function EQUALS(y) {
       if (IS_NULL_OR_UNDEFINED(y)) return 1;
       if (IS_NUMBER(y)) return %NumberEquals(%$toNumber(x), y);
       if (IS_STRING(y)) return %NumberEquals(%$toNumber(x), %$toNumber(y));
-      if (IS_SYMBOL(y) || IS_SIMD_OBJECT(y)) return 1;  // not equal
+      if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) return 1;  // not equal
       // y is object.
       x = %$toNumber(x);
       y = %$toPrimitive(y, NO_HINT);
     } else if (IS_NULL_OR_UNDEFINED(x)) {
       return IS_NULL_OR_UNDEFINED(y) ? 0 : 1;
-    } else if (IS_SIMD_OBJECT(x)) {
+    } else if (IS_SIMD_VALUE(x)) {
        return %SimdEquals(x, y);
     } else {
       // x is an object.
@@ -139,7 +139,7 @@ EQUALS = function EQUALS(y) {
       if (IS_NULL_OR_UNDEFINED(y)) return 1;  // not equal
       if (IS_BOOLEAN(y)) {
         y = %$toNumber(y);
-      } else if (IS_SYMBOL(y) || IS_SIMD_OBJECT(y)) {
+      } else if (IS_SYMBOL(y) || IS_SIMD_VALUE(y)) {
         return 1;  // not equal
       }
       x = %$toPrimitive(x, NO_HINT);
@@ -159,7 +159,7 @@ STRICT_EQUALS = function STRICT_EQUALS(x) {
     return %NumberEquals(this, x);
   }

-  if (IS_SIMD_OBJECT(this)) return %SimdEquals(this, x);
+  if (IS_SIMD_VALUE(this)) return %SimdEquals(this, x);

   // If anything else gets here, we just do simple identity check.
   // Objects (including functions), null, undefined and booleans were
@@ -756,7 +756,7 @@ function ToPrimitive(x, hint) {
   if (IS_STRING(x)) return x;
   // Normal behavior.
   if (!IS_SPEC_OBJECT(x)) return x;
-  if (IS_SIMD_OBJECT(x)) return x;
+  if (IS_SIMD_VALUE(x)) return x;
   if (hint == NO_HINT) hint = (IS_DATE(x)) ? STRING_HINT : NUMBER_HINT;
   return (hint == NUMBER_HINT) ? DefaultNumber(x) : DefaultString(x);
 }
@@ -862,7 +862,7 @@ function SameValue(x, y) {
       return false;
     }
   }
-  if (IS_SIMD_OBJECT(x)) return %SimdSameValue(x, y);
+  if (IS_SIMD_VALUE(x)) return %SimdSameValue(x, y);
   return x === y;
 }

@@ -873,7 +873,7 @@ function SameValueZero(x, y) {
   if (IS_NUMBER(x)) {
     if (NUMBER_IS_NAN(x) && NUMBER_IS_NAN(y)) return true;
   }
-  if (IS_SIMD_OBJECT(x)) return %SimdSameValueZero(x, y);
+  if (IS_SIMD_VALUE(x)) return %SimdSameValueZero(x, y);
   return x === y;
 }

@@ -917,7 +917,7 @@ function DefaultNumber(x) {
   if (IS_SPEC_FUNCTION(valueOf)) {
     var v = %_CallFunction(x, valueOf);
     if (IS_SYMBOL(v)) throw MakeTypeError(kSymbolToNumber);
-    if (IS_SIMD_OBJECT(x)) throw MakeTypeError(kSimdToNumber);
+    if (IS_SIMD_VALUE(x)) throw MakeTypeError(kSimdToNumber);
     if (IsPrimitive(v)) return v;
   }
   var toString = x.toString;
Index: src/runtime/runtime-simd.cc
diff --git a/src/runtime/runtime-simd.cc b/src/runtime/runtime-simd.cc
index ffb29c0586c2754e20c7874e1423357725b8a291..4c184aa66f27bc895807b3569b4b42bf47de3db0 100644 
--- a/src/runtime/runtime-simd.cc
+++ b/src/runtime/runtime-simd.cc
@@ -137,7 +137,7 @@ bool Equals(Float32x4* a, Float32x4* b) {
 }  // namespace


-RUNTIME_FUNCTION(Runtime_IsSimdObject) {
+RUNTIME_FUNCTION(Runtime_IsSimdValue) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);
   return isolate->heap()->ToBoolean(args[0]->IsSimd128Value());
Index: src/runtime/runtime.h
diff --git a/src/runtime/runtime.h b/src/runtime/runtime.h
index 6977cb6945065174d0e63761ed9f9edb966a972a..39656fa263efaaa2dcacb168fb2bfd54b26ca58e 100644 
--- a/src/runtime/runtime.h
+++ b/src/runtime/runtime.h
@@ -568,7 +568,7 @@ namespace internal {


 #define FOR_EACH_INTRINSIC_SIMD(F)    \
-  F(IsSimdObject, 1, 1)               \
+  F(IsSimdValue, 1, 1)                \
   F(SimdToObject, 1, 1)               \
   F(SimdEquals, 2, 1)                 \
   F(SimdSameValue, 2, 1)              \


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to