Comment #5 on issue 4330 by [email protected]: Deal with flakiness
for 'futex' on 'V8Linux64 TSAN'.
https://code.google.com/p/v8/issues/detail?id=4330#c5
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/e045b78d8ed1d0450f70baa44d16eda78f680188
commit e045b78d8ed1d0450f70baa44d16eda78f680188
Author: vogelheim <[email protected]>
Date: Tue Aug 04 14:31:41 2015
Avoid data race when writing Shell::options.script_executed.
The race occurred when Workers were used. Since Workers call
Shell::ExecuteString from a different thread, TSAN (correctly) flags
this as a racy write. Solution would be to either synchronize the writes,
or to 'lift' the write higher up in the call stack and only write the flag
from the main thread. This implements this latter solution.
These methods call Shell::ExecuteString, but do *not* set script_executed:
- ExecuteInThread: Can only occur is JS has already been executed.
- Shell::Load: Callback for JS; so JS has already been executed when
we get there.
- Shell::RunShell: Interactive shell. We no longer need script_executed once
we're here.
BUG=v8:4330
LOG=N
Review URL: https://codereview.chromium.org/1258303004
Cr-Commit-Position: refs/heads/master@{#30003}
[modify] http://crrev.com/e045b78d8ed1d0450f70baa44d16eda78f680188/src/d8.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
