Thank you for the good points and comments. I revised the code according to
the
reviews except one that is due to our testing limitation. If there are other
questions or conserns, please let me know.
http://codereview.chromium.org/569015/diff/3008/20
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/20#newcode56
src/arm/assembler-arm.cc:56: supported_ |= 1u << VFP3;
On 2010/02/03 07:56:09, Søren Gjesse wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/20#newcode866
src/arm/assembler-arm.cc:866: emit(cond | 0xF*B23 | 0x3*B21 | (0x1F &
src3.imm32_)*B16 |
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/20#newcode867
src/arm/assembler-arm.cc:867: dst.code()*B12 | (0x1F & src2.imm32_)*B7 |
0x5*B4 | src1.code());
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/19
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/19#newcode6018
src/arm/codegen-arm.cc:6018: // Remove tags from right operand.
On 2010/02/03 07:56:09, Søren Gjesse wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/19#newcode6024
src/arm/codegen-arm.cc:6024: // Use only the 5 least significant bits of
the shift count.
On 2010/02/03 07:56:09, Søren Gjesse wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/19#newcode6035
src/arm/codegen-arm.cc:6035: if (CpuFeatures::IsSupported(ARMv7)) {
We limit ubfx to ARMv7 since we don't have ARMv6T2 hardware to do the
testing. If we have that hardware in the future, we'll add the support
for ARMv6T2.
http://codereview.chromium.org/569015/diff/3008/22
File src/arm/disasm-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/22#newcode808
src/arm/disasm-arm.cc:808: if ((instr->HasW()) && (instr->HasW()) &&
(instr->Bits(6, 4) == 0x5)) {
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/22#newcode809
src/arm/disasm-arm.cc:809: unsigned int widthminus1 = (unsigned
int)(instr->Bits(20, 16));
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/22#newcode812
src/arm/disasm-arm.cc:812: if (msbit <=31) {
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/21
File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/21#newcode1771
src/arm/simulator-arm.cc:1771: if ((instr->HasW()) && (instr->HasW()) &&
(instr->Bits(6, 4) == 0x5)) {
On 2010/02/03 07:56:09, Søren Gjesse wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/21#newcode1772
src/arm/simulator-arm.cc:1772: unsigned int widthminus1 = (unsigned
int)(instr->Bits(20, 16));
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/21#newcode1775
src/arm/simulator-arm.cc:1775: if (msbit <=31) {
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015/diff/3008/23
File src/globals.h (right):
http://codereview.chromium.org/569015/diff/3008/23#newcode610
src/globals.h:610: ARMv7 = 2, // ARMv7
On 2010/02/03 09:17:56, Erik Corry wrote:
Done.
http://codereview.chromium.org/569015
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
