Addressed the arity issue by separating out a FormalParametersBase class
that
does not have an arity field, so that it only exists in the preparser. It
is now
updated in PreParserTraits::AddFormalParameter.
https://codereview.chromium.org/1259283002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1259283002/diff/1/src/parser.cc#newcode1205
src/parser.cc:1205: ParseFormalParameter(is_rest, &formals,
&formals_classifier, &ok);
On 2015/08/03 18:43:51, adamk wrote:
Check ok before declaring?
Done.
https://codereview.chromium.org/1259283002/diff/1/src/parser.cc#newcode2222
src/parser.cc:2222: !scope_->is_declaration_scope() ? LET : VAR;
On 2015/08/03 18:43:51, adamk wrote:
This looks unrelated to the rest of the change; maybe it's further
fixup from
the broadening of declaration scope definition?
You are right, I overlooked this one when splitting up the CL. It is
needed because there was some test started failing with this CL
otherwise. I can separate it out if you want.
https://codereview.chromium.org/1259283002/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1259283002/diff/1/src/parser.h#newcode1331
src/parser.h:1331: DCHECK(parameters->arity ==
parameters->params.length());
On 2015/08/03 18:43:52, adamk wrote:
Nit: DCHECK_EQ
Done.
https://codereview.chromium.org/1259283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
