https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.cc#newcode5153
src/heap/heap.cc:5153: Object* new_object = *slot;
On 2015/08/04 15:20:12, Michael Starzinger wrote:
nit: s/new_object/new_target/ for consistency.
Done.
https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/heap.h#newcode955
src/heap/heap.h:955: // from start to end of |object|.
On 2015/08/04 15:20:12, Michael Starzinger wrote:
nit: s/of/within/, otherwise it sounds like "end of object", which is
misleading.
Done.
https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/incremental-marking.cc#newcode216
src/heap/incremental-marking.cc:216: Object* obj = *p;
On 2015/08/04 16:09:22, ulan wrote:
s/obj/target here and in the function below to avoid confusion with
object.
Done.
https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-inl.h
File src/heap/mark-compact-inl.h (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact-inl.h#newcode58
src/heap/mark-compact-inl.h:58: void
MarkCompactCollector::RecordSlot(HeapObject* source, Object** slot,
On 2015/08/04 15:20:12, Michael Starzinger wrote:
nit: s/source/object/ for consistency.
Done.
https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/mark-compact.h#newcode658
src/heap/mark-compact.h:658: HeapObject* source, Object** slot, Object*
target,
On 2015/08/04 15:20:12, Michael Starzinger wrote:
nit: s/source/object/ for consistency.
Done.
https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiting.h
File src/heap/objects-visiting.h (right):
https://codereview.chromium.org/1259613006/diff/60001/src/heap/objects-visiting.h#newcode300
src/heap/objects-visiting.h:300: INLINE(static void VisitPointers(Heap*
heap, HeapObject* object,
On 2015/08/04 15:20:13, Michael Starzinger wrote:
Is this change for the StaticNewSpaceVisitor really necessary? This
one should
never be applied to LO-space objects. The StaticNewSpaceVisitor is
independent
from the StaticMarkingVisitor and hence its interface can be (and
already is)
out of sync.
Unfortunatly, BodyVisitorBase is used by both. We have to add it also to
the new space visitor.
https://codereview.chromium.org/1259613006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
