http://codereview.chromium.org/572003/diff/2001/3002 File src/runtime.cc (right):
http://codereview.chromium.org/572003/diff/2001/3002#newcode2909 src/runtime.cc:2909: if (result.IsProperty() && I think you should use result.IsValid() here - no reason to check which type of valid result it is more than once. http://codereview.chromium.org/572003/diff/2001/3001 File src/v8natives.js (right): http://codereview.chromium.org/572003/diff/2001/3001#newcode692 src/v8natives.js:692: return obj; Could you please add a test for this missing return, or do we already have a failing test for this? http://codereview.chromium.org/572003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
