LGTM, a few comments
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.cc#newcode249
src/heap/gc-idle-time-handler.cc:249: if
(heap_state.incremental_marking_stopped) return
GCIdleTimeAction::Done();
!FLAG_incremental_marking ||
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (left):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h#oldcode76
src/heap/gc-idle-time-handler.h:76: intptr_t parameter;
On 2015/08/05 11:11:59, ulan wrote:
This is gone because we estimate the step size outside of the idle
time handler.
ack
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/gc-idle-time-handler.h#newcode16
src/heap/gc-idle-time-handler.h:16: DO_INCREMENTAL_STEP,
On 2015/08/05 11:11:59, ulan wrote:
DO_INCREMENTAL_MARKING and DO_FINALIZE_SWEEPING are now combined into
DO_INCREMENTAL_STEP.
SGTM
https://codereview.chromium.org/1265423002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1265423002/diff/40001/src/heap/incremental-marking.cc#newcode1064
src/heap/incremental-marking.cc:1064: }
A follow-up CL could check if there is still time after waiting for
sweeper threads and perform incremental marking steps.
https://codereview.chromium.org/1265423002/diff/40001/src/heap/incremental-marking.cc#newcode1067
src/heap/incremental-marking.cc:1067: const double
remaining_idle_time_in_ms = heap->AdvanceIncrementalMarking(
AdvanceIncrementalMarking is always called with step size 0, let's
remove this parameter
https://codereview.chromium.org/1265423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
