https://codereview.chromium.org/1271253002/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1271253002/diff/20001/src/api.cc#newcode6888
src/api.cc:6888: using Heap = i::Heap;
On 2015/08/05 12:22:27, jochen wrote:
please don't use using.
Done.
https://codereview.chromium.org/1271253002/diff/20001/src/api.cc#newcode6889
src/api.cc:6889: double kIncrementalMarkingIntervalInMs = 3;
On 2015/08/05 12:22:27, jochen wrote:
On 2015/08/05 at 12:08:26, Michael Lippautz wrote:
> keep local?
maybe make it a flag?
Done.
https://codereview.chromium.org/1271253002/diff/20001/src/api.cc#newcode6889
src/api.cc:6889: double kIncrementalMarkingIntervalInMs = 3;
On 2015/08/05 12:39:36, Hannes Payer wrote:
I would prefer 1 instead of 3. The smaller the better.
It would be nice to calculate the value, based on memory pressure.
More ms for
higher memory pressure. That could be a TODO.
1ms it is. Works on N9.
Agree that it would be better to dynamically adjust the
time slices.
https://codereview.chromium.org/1271253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
