On 2015/08/03 10:38:18, Jarin wrote:
Looking good so far.
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/1263033004/diff/1/src/compiler/x64/code-generator-x64.cc#newcode1224
src/compiler/x64/code-generator-x64.cc:1224: __ subq(rsp, Immediate(8));
Maybe replace 8 with kDoubleSize?
PTAL. This CL has sprouted some tests which led me discovering bugs in frame
calculations and fixing them.
https://codereview.chromium.org/1263033004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
