Very nice. Thanks a lot for fixing this. LGTM.
http://codereview.chromium.org/573010/diff/1/3 File src/compiler.cc (right): http://codereview.chromium.org/573010/diff/1/3#newcode401 src/compiler.cc:401: LogCodeCreateEvent(Logger::LAZY_COMPILE_TAG, We don't indent based on #if, so this should be 2 spaces from the left, not 4. http://codereview.chromium.org/573010/diff/1/3#newcode556 src/compiler.cc:556: inline void Compiler::LogCodeCreateEvent(Logger::LogEventsAndTags tag, I don't think there is any point in having an inline function as the last thing in a .cc file. I think most compilers will fail to inline it because it is too late? http://codereview.chromium.org/573010/diff/1/3#newcode563 src/compiler.cc:563: // include script name and line number. Check explicit whether explicit->explicitly http://codereview.chromium.org/573010/diff/1/3#newcode564 src/compiler.cc:564: // logging is enabled as finding the line number is not for free. for free -> free http://codereview.chromium.org/573010 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
