Reviewers: Jakob,
Message:
PTAL
Description:
[test] Make test filters platform-independent.
Use the same path separator for test cases on the cmd-line
on all platforms as in testcase.GetLabel, which is used to
report failures.
BUG=chromium:511215
LOG=n
NOTRY=true
Please review this at https://codereview.chromium.org/1281453003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M tools/run-tests.py
M tools/testrunner/local/testsuite.py
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
a98bd40d88dd2745cfc94c4a6a554b47adecdd06..934d9d77cf853929383d28d261a621ec16e99dc7
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -505,7 +505,7 @@ def Main():
else:
args_suites = OrderedDict() # Used as set
for arg in args:
- args_suites[arg.split(os.path.sep)[0]] = True
+ args_suites[arg.split('/')[0]] = True
suite_paths = [ s for s in args_suites if s in suite_paths ]
suites = []
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py
b/tools/testrunner/local/testsuite.py
index
b7d20d108554d98af86b7e01d93d4ffb37b92012..c8e43521e71e8e3be99842d98bb8d250e0eb15c8
100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -221,7 +221,7 @@ class TestSuite(object):
globs = []
exact_matches = []
for a in args:
- argpath = a.split(os.path.sep)
+ argpath = a.split('/')
if argpath[0] != self.name:
continue
if len(argpath) == 1 or (len(argpath) == 2 and argpath[1] == '*'):
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
