Revision: 3796
Author: [email protected]
Date: Thu Feb 4 07:21:05 2010
Log: Fix presubmit errors.
[email protected]
Review URL: http://codereview.chromium.org/570024
http://code.google.com/p/v8/source/detail?r=3796
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.cc
/branches/bleeding_edge/src/arm/codegen-arm.h
/branches/bleeding_edge/src/fast-codegen.h
/branches/bleeding_edge/src/full-codegen.h
/branches/bleeding_edge/src/ia32/codegen-ia32.h
/branches/bleeding_edge/src/version.cc
/branches/bleeding_edge/src/x64/codegen-x64.h
=======================================
--- /branches/bleeding_edge/src/arm/codegen-arm.cc Thu Feb 4 01:11:43 2010
+++ /branches/bleeding_edge/src/arm/codegen-arm.cc Thu Feb 4 07:21:05 2010
@@ -225,7 +225,7 @@
Variable* par = scope()->parameter(i);
Slot* slot = par->slot();
if (slot != NULL && slot->type() == Slot::CONTEXT) {
- ASSERT(!scope()->is_global_scope()); // no parameters in
global scope
+ ASSERT(!scope()->is_global_scope()); // No params in global
scope.
__ ldr(r1, frame_->ParameterAt(i));
// Loads r2 with context; used below in RecordWrite.
__ str(r1, SlotOperand(slot, r2));
=======================================
--- /branches/bleeding_edge/src/arm/codegen-arm.h Thu Feb 4 01:11:43 2010
+++ /branches/bleeding_edge/src/arm/codegen-arm.h Thu Feb 4 07:21:05 2010
@@ -208,7 +208,7 @@
private:
// Construction/Destruction
- CodeGenerator(MacroAssembler* masm);
+ explicit CodeGenerator(MacroAssembler* masm);
// Accessors
inline bool is_eval();
=======================================
--- /branches/bleeding_edge/src/fast-codegen.h Wed Feb 3 08:12:55 2010
+++ /branches/bleeding_edge/src/fast-codegen.h Thu Feb 4 07:21:05 2010
@@ -42,7 +42,7 @@
: info_(NULL), has_supported_syntax_(true) {
}
- void Check(CompilationInfo* info);
+ void Check(CompilationInfo* info);
CompilationInfo* info() { return info_; }
bool has_supported_syntax() { return has_supported_syntax_; }
@@ -65,7 +65,7 @@
class FastCodeGenerator: public AstVisitor {
public:
- FastCodeGenerator(MacroAssembler* masm) : masm_(masm), info_(NULL) {}
+ explicit FastCodeGenerator(MacroAssembler* masm) : masm_(masm),
info_(NULL) {}
static Handle<Code> MakeCode(CompilationInfo* info);
=======================================
--- /branches/bleeding_edge/src/full-codegen.h Wed Feb 3 08:12:55 2010
+++ /branches/bleeding_edge/src/full-codegen.h Thu Feb 4 07:21:05 2010
@@ -68,7 +68,7 @@
SECONDARY
};
- FullCodeGenerator(MacroAssembler* masm)
+ explicit FullCodeGenerator(MacroAssembler* masm)
: masm_(masm),
info_(NULL),
nesting_stack_(NULL),
=======================================
--- /branches/bleeding_edge/src/ia32/codegen-ia32.h Wed Feb 3 08:12:55 2010
+++ /branches/bleeding_edge/src/ia32/codegen-ia32.h Thu Feb 4 07:21:05 2010
@@ -348,7 +348,7 @@
private:
// Construction/Destruction
- CodeGenerator(MacroAssembler* masm);
+ explicit CodeGenerator(MacroAssembler* masm);
// Accessors
inline bool is_eval();
=======================================
--- /branches/bleeding_edge/src/version.cc Wed Feb 3 01:15:58 2010
+++ /branches/bleeding_edge/src/version.cc Thu Feb 4 07:21:05 2010
@@ -34,7 +34,7 @@
// cannot be changed without changing the SCons build script.
#define MAJOR_VERSION 2
#define MINOR_VERSION 1
-#define BUILD_NUMBER 1
+#define BUILD_NUMBER 1
#define PATCH_LEVEL 0
#define CANDIDATE_VERSION true
=======================================
--- /branches/bleeding_edge/src/x64/codegen-x64.h Wed Feb 3 08:12:55 2010
+++ /branches/bleeding_edge/src/x64/codegen-x64.h Thu Feb 4 07:21:05 2010
@@ -348,7 +348,7 @@
private:
// Construction/Destruction
- CodeGenerator(MacroAssembler* masm);
+ explicit CodeGenerator(MacroAssembler* masm);
// Accessors
inline bool is_eval();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
