https://codereview.chromium.org/1230343003/diff/140001/src/harmony-simd.js
File src/harmony-simd.js (right):
https://codereview.chromium.org/1230343003/diff/140001/src/harmony-simd.js#newcode11
src/harmony-simd.js:11: var $bool8x16ToString;
On 2015/08/06 00:12:25, Dan Ehrenberg wrote:
You're supposed to use the new export/import system these days rather
than
properties of the global object. See src/harmony-arrays.js for an
example.
Done.
https://codereview.chromium.org/1230343003/diff/140001/src/harmony-simd.js#newcode106
src/harmony-simd.js:106: return %NAMESelect(selector, a, b);
On 2015/08/06 00:12:25, Dan Ehrenberg wrote:
The spec v0.7.3 defines select only on numeric types, but equal and
notEqual on
all types. You did the reverse here. Do you think the spec should be
changed? I
don't feel so strongly about it.
No, select on boolean types doesn't seem useful. Done. (Equal and
NotEqual are OK)
https://codereview.chromium.org/1230343003/diff/140001/src/runtime/runtime-simd.cc
File src/runtime/runtime-simd.cc (right):
https://codereview.chromium.org/1230343003/diff/140001/src/runtime/runtime-simd.cc#newcode62
src/runtime/runtime-simd.cc:62: inline float RecipSqrtApprox(float a) {
return 1.0f / std::sqrt(a); }
On 2015/08/06 00:12:25, Dan Ehrenberg wrote:
We may have to revisit these at some point, to create consistent
results for
optimized code vs fullcodegen.
I'll add a TODO.
https://codereview.chromium.org/1230343003/diff/140001/src/runtime/runtime-simd.cc#newcode429
src/runtime/runtime-simd.cc:429: shift = shift & 0x3f;
\
On 2015/08/06 00:12:25, Dan Ehrenberg wrote:
Looks like you're implementing wrap-around behavior here (like JS <<).
However,
SIMD operations max out at 0 for shifting too far left; see
http://littledan.github.io/simd.html#simd-shift-left-by-scalar . This
is done to
match what the processors apparently do. Analogous behavior exists on
the right
shifts.
Done.
https://codereview.chromium.org/1230343003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
