Reviewers: paul.l..., ilija.pavlovic_imgtec.com, akos.palfi.imgtec,
balazs.kilvady,
https://codereview.chromium.org/1276813004/diff/1/test/cctest/test-assembler-mips.cc
File test/cctest/test-assembler-mips.cc (right):
https://codereview.chromium.org/1276813004/diff/1/test/cctest/test-assembler-mips.cc#newcode1805
test/cctest/test-assembler-mips.cc:1805: const int tableLength = 15;
On 2015/08/07 04:48:14, paul.l... wrote:
nit: name capitalization does not conform to style guide. Since it's a
const, I
suggest kTableLength
Done. Also changed tableLength to kTableLength in other assembler tests.
https://codereview.chromium.org/1276813004/diff/1/test/cctest/test-assembler-mips.cc#newcode1811
test/cctest/test-assembler-mips.cc:1811: const float fltNaN =
std::numeric_limits<float>::quiet_NaN();
On 2015/08/07 04:48:14, paul.l... wrote:
nit: these two names also don't conform. Suggest dbl_nan, and flt_nan.
I
actually prefer spelling them out, since 'flt' isn't so mnemonic to
me:
float_nan, double_nan.
It would be nice if you fix the similar names in TEST(min_max) as
well.
Done.
https://codereview.chromium.org/1276813004/diff/1/test/cctest/test-assembler-mips64.cc
File test/cctest/test-assembler-mips64.cc (right):
https://codereview.chromium.org/1276813004/diff/1/test/cctest/test-assembler-mips64.cc#newcode1907
test/cctest/test-assembler-mips64.cc:1907: const int tableLength = 15;
On 2015/08/07 04:48:14, paul.l... wrote:
Same comment as in 32-bit versionL kTableLength, double_nan, and
float_nan.
Done. Also changed tableLength to kTableLength in other assembler tests.
I added some changes in class_fmt, actually NaN checks
Description:
MIPS: Fix mina_maxa for proper NaN handling.
Also clean up variable naming in min_max and other tests. Fix class_fmt in
mips64 assembler test for proper NaN checking
Please review this at https://codereview.chromium.org/1276813004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+322, -332 lines):
M test/cctest/test-assembler-mips.cc
M test/cctest/test-assembler-mips64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
