On 2015/08/07 07:59:03, Michael Starzinger wrote:
LGTM.
Is there a particular reason to have five different linkage.cc files with
one
method each? I would consider it more intuitive to have all of these
methods
in
the linkage.cc file instead.
https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-linkage.cc
File src/compiler/interpreter-linkage.cc (right):
https://codereview.chromium.org/1272883003/diff/1/src/compiler/interpreter-linkage.cc#newcode46
src/compiler/interpreter-linkage.cc:46: }
nit:
} // namespace compiler
} // namespace internal
} // namespace v8
https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc
File src/compiler/js-linkage.cc (right):
https://codereview.chromium.org/1272883003/diff/1/src/compiler/js-linkage.cc#newcode58
src/compiler/js-linkage.cc:58: }
nit:
} // namespace compiler
} // namespace internal
} // namespace v8
https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h
File src/compiler/linkage-impl.h (right):
https://codereview.chromium.org/1272883003/diff/1/src/compiler/linkage-impl.h#newcode6
src/compiler/linkage-impl.h:6: #define V8_COMPILER_LINKAGE_IMPL_H_
Is there still a reason for this file to exist or could the below three
definitions just be moved into the linkage.h file instead?
Done.
https://codereview.chromium.org/1272883003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
