https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#oldcode2245
src/heap/mark-compact.cc:2245: incremental_marking->Stop();
On 2015/08/07 09:57:31, Hannes Payer wrote:
stop is now not called for non-aborting GCs. We should take care of
that in
prepare.
Done. Yep, my think-o, the try-jobs caught that.
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1273953004/diff/1/src/heap/mark-compact.cc#newcode2239
src/heap/mark-compact.cc:2239: IncrementalMarking* incremental_marking =
heap_->incremental_marking();
On 2015/08/07 09:57:31, Hannes Payer wrote:
It would be nicer to move the chunk of code that deals with
incremental marking
to the prepare function.
Acknowledged. Would you be fine with doing that in a separate CL or
should I do it in this one?
https://codereview.chromium.org/1273953004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
