LGTM, I'm fine with landing this as a temporary hack, but can we have a
couple
of comments (and perhaps TODOs) clarifying why it was introduced?
CC'ing Benedikt.
https://codereview.chromium.org/1281883002/diff/1/src/scopeinfo.cc
File src/scopeinfo.cc (right):
https://codereview.chromium.org/1281883002/diff/1/src/scopeinfo.cc#newcode591
src/scopeinfo.cc:591: int total_count = scope_info->ContextLocalCount();
So, this means that lexical variable lookup does not use the cache
anymore? That is going to make it worse in some cases. At least add a
TODO.
https://codereview.chromium.org/1281883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
