There are definitely more comments to fix. I only grepped for the ones
starting
a line.
http://codereview.chromium.org/574009/diff/1/2
File src/ia32/assembler-ia32.cc (right):
http://codereview.chromium.org/574009/diff/1/2#newcode349
src/ia32/assembler-ia32.cc:349: ASSERT(pc_ <= reloc_info_writer.pos());
// no overlap
On 2010/02/04 20:47:13, Erik Corry wrote:
Missed one!
Done.
http://codereview.chromium.org/574009/diff/1/2#newcode767
src/ia32/assembler-ia32.cc:767: if (src.is(eax) || dst.is(eax)) { //
Single-byte encoding
On 2010/02/04 20:47:13, Erik Corry wrote:
And here.
Done.
http://codereview.chromium.org/574009/diff/1/5
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/574009/diff/1/5#newcode342
src/x64/assembler-x64.cc:342: ASSERT(pc_ <= reloc_info_writer.pos());
// no overlap
On 2010/02/04 20:47:13, Erik Corry wrote:
And here.
Done.
http://codereview.chromium.org/574009/diff/1/5#newcode392
src/x64/assembler-x64.cc:392: ASSERT(buffer_overflow()); // should not
call this otherwise
On 2010/02/04 20:47:13, Erik Corry wrote:
Superfluous comment is wrongly formatted.
Removed (and in assembler-ia32.cc as well).
http://codereview.chromium.org/574009/diff/1/5#newcode421
src/x64/assembler-x64.cc:421: //Ccopy the data.
On 2010/02/04 20:47:13, Erik Corry wrote:
Oops.
Done.
http://codereview.chromium.org/574009
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
