Reviewers: jochen (traveling - slow),
Description:
[api] Delete non-maybe version of CompileModule
Also add a bigger warning to the header comment for the Maybe version.
[email protected]
Please review this at https://codereview.chromium.org/1276353003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -5 lines):
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
19373a1398720ad1816df0dfd49ec5f8f88a86c0..38a9e7c6662c2df125eb38fcf0fa109de966c38d
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1385,15 +1385,13 @@ class V8_EXPORT ScriptCompiler {
/**
* Compile an ES6 module.
*
- * This is an experimental feature.
+ * This is an unfinished experimental feature, and is only exposed
+ * here for internal testing purposes.
+ * Only parsing works at the moment. Do not use.
*
* TODO(adamk): Script is likely the wrong return value for this;
* should return some new Module type.
*/
- static V8_DEPRECATE_SOON(
- "Use maybe version",
- Local<Script> CompileModule(Isolate* isolate, Source* source,
- CompileOptions options =
kNoCompileOptions));
static V8_WARN_UNUSED_RESULT MaybeLocal<Script> CompileModule(
Local<Context> context, Source* source,
CompileOptions options = kNoCompileOptions);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
