Reviewers: Michael Lippautz,
Description:
[heap] Remove obsolete constructors from SemiSpaceIterator.
[email protected]
Please review this at https://codereview.chromium.org/1284643003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -21 lines):
M src/heap/mark-compact.cc
M src/heap/spaces.h
M src/heap/spaces.cc
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index
f9eeaad0fca4df8a761ad1d1acba3ffc13451a30..db35126ad0f19dc7ed49cd7ea31d23c474069db2
100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -3657,8 +3657,7 @@ void
MarkCompactCollector::EvacuateNewSpaceAndCandidates() {
GCTracer::Scope gc_scope(heap()->tracer(),
GCTracer::Scope::MC_UPDATE_NEW_TO_NEW_POINTERS);
// Update pointers in to space.
- SemiSpaceIterator to_it(heap()->new_space()->bottom(),
- heap()->new_space()->top());
+ SemiSpaceIterator to_it(heap()->new_space());
for (HeapObject* object = to_it.Next(); object != NULL;
object = to_it.Next()) {
Map* map = object->map();
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index
9812abdf1e93cc6071938e84e198eff5513f7dfc..ee7751a5a89bf28abf6b0984ea12c554f5c000e7
100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -1846,21 +1846,12 @@ void SemiSpace::AssertValidRange(Address start,
Address end) {
//
-----------------------------------------------------------------------------
// SemiSpaceIterator implementation.
+
SemiSpaceIterator::SemiSpaceIterator(NewSpace* space) {
Initialize(space->bottom(), space->top());
}
-SemiSpaceIterator::SemiSpaceIterator(NewSpace* space, Address start) {
- Initialize(start, space->top());
-}
-
-
-SemiSpaceIterator::SemiSpaceIterator(Address from, Address to) {
- Initialize(from, to);
-}
-
-
void SemiSpaceIterator::Initialize(Address start, Address end) {
SemiSpace::AssertValidRange(start, end);
current_ = start;
Index: src/heap/spaces.h
diff --git a/src/heap/spaces.h b/src/heap/spaces.h
index
f225bbc80fd0d0c83661067870b43b434ff447b2..11af00febd9d1371eccd95a9d71eb6a664a7a2cf
100644
--- a/src/heap/spaces.h
+++ b/src/heap/spaces.h
@@ -2274,16 +2274,8 @@ class SemiSpace : public Space {
// iterator is created are not iterated.
class SemiSpaceIterator : public ObjectIterator {
public:
- // Create an iterator over the objects in the given space. If no start
- // address is given, the iterator starts from the bottom of the space.
-
- // Iterate over all of allocated to-space.
+ // Create an iterator over the allocated objects in the given to-space.
explicit SemiSpaceIterator(NewSpace* space);
- // Iterate over part of allocated to-space, from start to the end
- // of allocation.
- SemiSpaceIterator(NewSpace* space, Address start);
- // Iterate from one address to another in the same semi-space.
- SemiSpaceIterator(Address from, Address to);
HeapObject* Next() {
if (current_ == limit_) return NULL;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
