LGTM
http://codereview.chromium.org/573018/diff/1/6 File src/bootstrapper.cc (right): http://codereview.chromium.org/573018/diff/1/6#newcode381 src/bootstrapper.cc:381: return active_ != 0 || Genesis::current() != NULL; Can we get rid of the Genesis::current() check and make sure to use BootStrapperActive always when bootstrapping? http://codereview.chromium.org/573018/diff/1/6#newcode1267 src/bootstrapper.cc:1267: if (!Debug::Load()) Either make this a one-liner or use braces around the body. http://codereview.chromium.org/573018/diff/1/5 File src/bootstrapper.h (right): http://codereview.chromium.org/573018/diff/1/5#newcode83 src/bootstrapper.h:83: class BootstrapperActive { You should add BASE_EMBEDDED here to make sure that this can only be stack allocated. http://codereview.chromium.org/573018/diff/1/5#newcode89 src/bootstrapper.h:89: static int active_; The name 'active_' makes me think it should be a bool. How about 'nesting_'? http://codereview.chromium.org/573018 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
