Reviewers: Michael Lippautz,
Description:
[heap] Avoid inclusion of heap internals in v8.h header.
[email protected]
Please review this at https://codereview.chromium.org/1283833002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -8 lines):
M src/DEPS
M src/heap/heap-inl.h
M src/v8.h
Index: src/DEPS
diff --git a/src/DEPS b/src/DEPS
index
80dab6ba70c6b915b121d9e3950cdb29cf8e27f7..021cd3bf2d94c0fece6769fc60111ee5c12d3b67
100644
--- a/src/DEPS
+++ b/src/DEPS
@@ -16,11 +16,6 @@ specific_include_rules = {
"d8\.cc": [
"+include/libplatform/libplatform.h",
],
- # TODO(mstarzinger): Get rid of grab-bag includes from heap in v8.h soon.
- "v8\.h": [
- "+src/heap/spaces-inl.h",
- "+src/heap/incremental-marking-inl.h",
- ],
# TODO(mstarzinger): Only needed because of Code::CodeIterateBody
cyclicity.
"objects\.cc": [
"+src/heap/objects-visiting-inl.h",
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index
fdb1d7345b4d79c0e738f39ab879667f4e604048..45ba3794c46c9f61b3271a9cbc95fa973ddc60ed
100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -9,6 +9,8 @@
#include "src/base/platform/platform.h"
#include "src/heap/heap.h"
+#include "src/heap/incremental-marking-inl.h"
+#include "src/heap/spaces-inl.h"
#include "src/heap/store-buffer.h"
#include "src/heap/store-buffer-inl.h"
#include "src/heap-profiler.h"
Index: src/v8.h
diff --git a/src/v8.h b/src/v8.h
index
41d4c36b4ddb074a7c06775892a16964937e6d12..c516cacdf8be0ff24719f3b73c9a5dca33b309d3
100644
--- a/src/v8.h
+++ b/src/v8.h
@@ -35,10 +35,8 @@
#include "src/flags.h" // NOLINT
#include "src/globals.h" // NOLINT
-// Objects & heap
+// Objects
#include "src/objects-inl.h" // NOLINT
-#include "src/heap/spaces-inl.h" // NOLINT
-#include "src/heap/incremental-marking-inl.h" // NOLINT
#include "src/log-inl.h" // NOLINT
#include "src/handles-inl.h" // NOLINT
#include "src/types-inl.h" // NOLINT
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
