Reviewers: Benedikt Meurer, Hannes Payer, titzer,
Message:
PTAL all reviewers, I would like to get sign-of on the below steps (1)-(3)
from
all reviewers. The optional step (4) only needs to be done once. Thanks!
Review-Instructions:
1) Read CL description of what the goal is.
2) Look at "DEPS" for the new rules of the game.
3) Look at "v8.h" for major awesomeness.
4) Look at the rest.
https://codereview.chromium.org/1282503003/diff/1/src/v8.h
File src/v8.h (left):
https://codereview.chromium.org/1282503003/diff/1/src/v8.h#oldcode85
src/v8.h:85: enum NilValue { kNullValue, kUndefinedValue };
Note that this has been moved to the globals.h file.
Description:
Remove several grab-bag includes from the v8.h header.
This is the first step of turning the v8.h file into a normal header
instead of an include-the-world header. The new rule is that no other
header files are allowed to include v8.h, which is enforced by DEPS.
Also the number of includes inside the v8.h file has been drastically
reduced. Basically the last missing piece is the inclusion of the big
objects-inl.h file.
This in turn makes many headers follow the IWYU principle.
[email protected],[email protected],[email protected]
Please review this at https://codereview.chromium.org/1282503003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+46, -87 lines):
M src/DEPS
M src/accessors.h
M src/api.h
M src/api.cc
M src/arm/lithium-gap-resolver-arm.h
M src/arm64/constants-arm64.h
M src/arm64/disasm-arm64.h
M src/arm64/lithium-gap-resolver-arm64.h
M src/arm64/simulator-arm64.h
M src/arm64/utils-arm64.h
M src/assembler.h
M src/ast.h
M src/ast-literal-reindexer.h
M src/basic-block-profiler.h
M src/compiler.cc
M src/compiler/basic-block-instrumentor.h
M src/d8.h
M src/deoptimizer.h
M src/effects.h
M src/expression-classifier.h
M src/extensions/externalize-string-extension.h
M src/extensions/externalize-string-extension.cc
M src/extensions/free-buffer-extension.h
M src/extensions/gc-extension.h
M src/extensions/statistics-extension.h
M src/extensions/statistics-extension.cc
M src/extensions/trigger-failure-extension.h
M src/full-codegen/full-codegen.h
M src/gdb-jit.h
M src/globals.h
M src/hydrogen.h
M src/hydrogen-instructions.h
M src/i18n.h
M src/i18n.cc
M src/ia32/lithium-gap-resolver-ia32.h
M src/json-parser.h
M src/json-stringifier.h
M src/lithium-allocator.h
M src/lithium-codegen.h
M src/mips/lithium-gap-resolver-mips.h
M src/mips64/lithium-gap-resolver-mips64.h
M src/objects-inl.h
M src/ppc/lithium-gap-resolver-ppc.h
M src/preparser.h
M src/regexp-macro-assembler-irregexp.h
M src/regexp-macro-assembler-irregexp-inl.h
M src/string-builder.h
M src/typing.h
M src/v8.h
M src/x64/lithium-gap-resolver-x64.h
M src/x87/lithium-gap-resolver-x87.h
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
