On 2015/08/11 08:13:36, Yang wrote:
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):
https://codereview.chromium.org/1264993002/diff/60001/src/debug/debug-scopes.cc#newcode86
src/debug/debug-scopes.cc:86: Handle<ScopeInfo>
scope_info(shared_info->scope_info());
On 2015/08/10 18:08:08, brucedawson wrote:
> This variable shadows the same-named variable in the outer scope
declared at
> line 33. This is probably harmless but perhaps (I really don't know)
inefficient
> since they seem to be recording the same information.
>
> FYI.
>
> This was noticed as a new /analyze warning:
> debug-scopes.cc(86) : warning C6246: Local declaration of 'scope_info'
hides
> declaration of the same name in outer scope. See previous declaration at
line
> '33'.
>
> Fixing is not required.
You are right. This is indeed redundant. I simply copied over old code
and did
not notice. I'll follow up with a new CL.
Said follow-up: https://codereview.chromium.org/1286653004
https://codereview.chromium.org/1264993002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
