Reviewers: Yang,
Description:
Remove grab-bag includes of v8.h from debugger.
[email protected]
Please review this at https://codereview.chromium.org/1283023002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fullcode
Affected files (+1, -25 lines):
M src/debug/arm/debug-arm.cc
M src/debug/arm64/debug-arm64.cc
M src/debug/debug.cc
M src/debug/ia32/debug-ia32.cc
M src/debug/liveedit.cc
M src/debug/mips/debug-mips.cc
M src/debug/mips64/debug-mips64.cc
M src/debug/ppc/debug-ppc.cc
M src/debug/x64/debug-x64.cc
M src/debug/x87/debug-x87.cc
Index: src/debug/arm/debug-arm.cc
diff --git a/src/debug/arm/debug-arm.cc b/src/debug/arm/debug-arm.cc
index
38aadceae01be972245c7de77b6e3ad590267c01..7f1542e18308e193fb7dadd09047159199c4c00f
100644
--- a/src/debug/arm/debug-arm.cc
+++ b/src/debug/arm/debug-arm.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_ARM
#include "src/codegen.h"
Index: src/debug/arm64/debug-arm64.cc
diff --git a/src/debug/arm64/debug-arm64.cc b/src/debug/arm64/debug-arm64.cc
index
e33c1a51564fac7e3d72012ab861f5d3677e6004..e92227161ac6f6a0aa4bec5329f1ffd78460c65c
100644
--- a/src/debug/arm64/debug-arm64.cc
+++ b/src/debug/arm64/debug-arm64.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_ARM64
#include "src/codegen.h"
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index
55837342eb9e9547ea300f6d331fbe519ddfc1b9..e2ffdfe1d7d0decb683080f6801cbb184e46c9ad
100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#include "src/debug/debug.h"
#include "src/api.h"
Index: src/debug/ia32/debug-ia32.cc
diff --git a/src/debug/ia32/debug-ia32.cc b/src/debug/ia32/debug-ia32.cc
index
cf21bd8d34965e947ae7594db34b402d89a7c00a..3c00b3f41dd9667a9000a931c069401994077400
100644
--- a/src/debug/ia32/debug-ia32.cc
+++ b/src/debug/ia32/debug-ia32.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_IA32
#include "src/codegen.h"
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index
5cb75923273459001b29655685e7238ec152968a..f132b62ee992b46af5702ced054b9197e465d823
100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -2,9 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
-#include "src/v8.h"
-
#include "src/debug/liveedit.h"
#include "src/code-stubs.h"
@@ -17,6 +14,7 @@
#include "src/parser.h"
#include "src/scopeinfo.h"
#include "src/scopes.h"
+#include "src/v8.h"
#include "src/v8memory.h"
namespace v8 {
Index: src/debug/mips/debug-mips.cc
diff --git a/src/debug/mips/debug-mips.cc b/src/debug/mips/debug-mips.cc
index
5c6208f5c75f42c7b251f46f51be6908e01e74e9..30bdcac1b6f1c0d0b09fc7a56d17ce620cbf5606
100644
--- a/src/debug/mips/debug-mips.cc
+++ b/src/debug/mips/debug-mips.cc
@@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
-
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_MIPS
#include "src/codegen.h"
Index: src/debug/mips64/debug-mips64.cc
diff --git a/src/debug/mips64/debug-mips64.cc
b/src/debug/mips64/debug-mips64.cc
index
2665334fb8dda7006fc0bf63df600616eb57615a..9b4d355d796da3ff9b60f10a6e77c00b0e5b3b28
100644
--- a/src/debug/mips64/debug-mips64.cc
+++ b/src/debug/mips64/debug-mips64.cc
@@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
-
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_MIPS64
#include "src/codegen.h"
Index: src/debug/ppc/debug-ppc.cc
diff --git a/src/debug/ppc/debug-ppc.cc b/src/debug/ppc/debug-ppc.cc
index
a23782a98bcc14e2e5b75e3d50dd9930dc2c575d..ed4a632475c5af444c5aeb33433b81ca822c87e3
100644
--- a/src/debug/ppc/debug-ppc.cc
+++ b/src/debug/ppc/debug-ppc.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_PPC
#include "src/codegen.h"
Index: src/debug/x64/debug-x64.cc
diff --git a/src/debug/x64/debug-x64.cc b/src/debug/x64/debug-x64.cc
index
6cb653d9b0ceb29223040747ba3f9299d2da729e..3b656787091ecd04d6437c81870a6e9fcec89033
100644
--- a/src/debug/x64/debug-x64.cc
+++ b/src/debug/x64/debug-x64.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_X64
#include "src/assembler.h"
Index: src/debug/x87/debug-x87.cc
diff --git a/src/debug/x87/debug-x87.cc b/src/debug/x87/debug-x87.cc
index
f0e39af335f2fa4a64f67a96e34aedda8aaf7475..07812e1d5085ec7391d465880f66e054a8652935
100644
--- a/src/debug/x87/debug-x87.cc
+++ b/src/debug/x87/debug-x87.cc
@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "src/v8.h"
-
#if V8_TARGET_ARCH_X87
#include "src/codegen.h"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
