LGTM
I think storing 0 into the code slot is a leftover which is not used any
more.
Lasse, I seem to remember that you removed some of the special markers
stored in
the code slot at some point (during the x64 port perhaps). Was this maybe
left
at that point?
http://codereview.chromium.org/561049/diff/4027/3121
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/561049/diff/4027/3121#newcode337
src/arm/macro-assembler-arm.cc:337: push(ip); // accessed from
EditFrame::code_slot
Initial letter uppercase, end with period, no class called EditFrame.
http://codereview.chromium.org/561049/diff/4027/3116
File src/assembler.cc (right):
http://codereview.chromium.org/561049/diff/4027/3116#newcode432
src/assembler.cc:432: return "code target (context)";
Change this to
case RelocInfo::DEBUG_BREAK:
#ifdef ENABLE_DEBUGGER_SUPPORT
return "debug break";
#else
UNREACHABLE();
#endif
http://codereview.chromium.org/561049/diff/4027/3116#newcode493
src/assembler.cc:493: case CODE_TARGET_CONTEXT:
Something like above, or just remove the #ifdef/#endif.
http://codereview.chromium.org/561049/diff/4027/3108
File src/assembler.h (right):
http://codereview.chromium.org/561049/diff/4027/3108#newcode122
src/assembler.h:122: #ifdef ENABLE_DEBUGGER_SUPPORT
I think we should avoid the #ifdef/#endif here to always have the same
id for reloc modes.
http://codereview.chromium.org/561049/diff/4027/3102
File src/ia32/macro-assembler-ia32.cc (right):
http://codereview.chromium.org/561049/diff/4027/3102#newcode407
src/ia32/macro-assembler-ia32.cc:407: push(Immediate(CodeObject())); //
accessed from EditFrame::code_slot
See previous comment on comment.
http://codereview.chromium.org/561049/diff/4027/3110
File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/561049/diff/4027/3110#newcode1965
src/x64/macro-assembler-x64.cc:1965: push(kScratchRegister); //
accessed from EditFrame::code_slot
See previous comment on comment.
http://codereview.chromium.org/561049
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
