Reviewers: Igor Sheludko,

Message:
This was introduced in the past month. I see it a lot when I build v8 as part of
PDFium with Clang.

Description:
LoadGlobalParameters::slot_index() should just return an int.

Clang says: warning: 'const' type qualifier on return type has no effect
[-Wignored-qualifiers]

Please review this at https://codereview.chromium.org/1284013003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1, -1 lines):
  M src/compiler/js-operator.h


Index: src/compiler/js-operator.h
diff --git a/src/compiler/js-operator.h b/src/compiler/js-operator.h
index 26d7e6236548cd82a846e0d04e61b838a74e575c..5afbfdf6faf11ce8ffb443acf4f33750dd7e7a50 100644
--- a/src/compiler/js-operator.h
+++ b/src/compiler/js-operator.h
@@ -277,7 +277,7 @@ class LoadGlobalParameters final {

   const VectorSlotPair& feedback() const { return feedback_; }

-  const int slot_index() const { return slot_index_; }
+  int slot_index() const { return slot_index_; }

  private:
   const Unique<Name> name_;


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to