Glad to see these tests tightened up, this stuff was clearly under-tested
before
(since class has its own path in the parser).
https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/es6/block-scoping.js
File test/mjsunit/es6/block-scoping.js (right):
https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/es6/block-scoping.js#newcode282
test/mjsunit/es6/block-scoping.js:282: //assertEquals(1,f.foo());
Why is this commented out?
https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/harmony/block-scoping-sloppy.js
File test/mjsunit/harmony/block-scoping-sloppy.js (right):
https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/harmony/block-scoping-sloppy.js#newcode31
test/mjsunit/harmony/block-scoping-sloppy.js:31: "use strict";
I don't think this should be strict...
https://codereview.chromium.org/1286923002/diff/1/test/mjsunit/harmony/block-scoping-sloppy.js#newcode282
test/mjsunit/harmony/block-scoping-sloppy.js:282:
//assertEquals(1,f.foo());
Another odd comment; is something broken?
https://codereview.chromium.org/1286923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
