LGTM with nits.
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js
File src/debug/mirrors.js (right):
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js#newcode20
src/debug/mirrors.js:20: // - ValueMirror
nit: meaningful indentation got lost here
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js#newcode71
src/debug/mirrors.js:71: //Handle id counters.
nit: space after //
https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js#newcode3057
src/debug/mirrors.js:3057: %AddNamedProperty(global, "MakeMirror",
MakeMirror, DONT_ENUM);
is there a specific reason to use %AddNamedProperty() rather than
utils.InstallFunctions() ?
https://codereview.chromium.org/1282793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
