A couple areas I wasn't as sure about:
https://codereview.chromium.org/1289603002/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1289603002/diff/40001/src/bootstrapper.cc#newcode2611
src/bootstrapper.cc:2611: if (context_type == THIN_CONTEXT) {
This maybe should be != FULL_CONTEXT?
https://codereview.chromium.org/1289603002/diff/40001/src/snapshot/serialize.h
File src/snapshot/serialize.h (right):
https://codereview.chromium.org/1289603002/diff/40001/src/snapshot/serialize.h#newcode406
src/snapshot/serialize.h:406: static const int
kExtraNativesStringResource = 0x5e;
Wasn't sure if there was a pattern here that was supposed to be followed
so I just took an unused code...
https://codereview.chromium.org/1289603002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
