On 2015/08/12 17:48:41, Michael Starzinger wrote:
LGTM.
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc
File test/cctest/compiler/test-run-native-calls.cc (right):
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc#newcode33
test/cctest/compiler/test-run-native-calls.cc:33: // Picks a
representative
set
of integers from the gi
nit: comment looks incomplete.
Done.
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc#newcode76
test/cctest/compiler/test-run-native-calls.cc:76: // printf("pair = %d,
%d\n", *r0, *r1);
nit: Looks like a leftover.
Done.
https://codereview.chromium.org/1291553005/diff/1/test/cctest/compiler/test-run-native-calls.cc#newcode406
test/cctest/compiler/test-run-native-calls.cc:406: void
ArgsBuffer<CType>::Mutate() {
Can we just skip the non-specialized implementation? Thereby using it
with a
new
type parameter will produce a link-time error.
Done.
https://codereview.chromium.org/1291553005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
