lgtm with a nit and a question.
https://codereview.chromium.org/1287203002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1287203002/diff/1/src/hydrogen.cc#newcode10907
src/hydrogen.cc:10907: if (left_type->Is(Type::String())) {
Could not you say here
if (left_type->Is(Type::String()) || is_strong(strength)) {
left = BuildCheckString(left);
}
And then below say
if (!left_type->Is(Type::String()) && !is_strong(strength)) {
DCHECK(right_type->Is(Type::String()));
if (left_type->Is(Type::Number())) {
...
https://codereview.chromium.org/1287203002/diff/1/src/hydrogen.cc#newcode10920
src/hydrogen.cc:10920: // In strong mode, if the left hand side of an
additition is a string,
additition -> addition (Here and below.)
https://codereview.chromium.org/1287203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
