lgtm. A couple of trivial comments, but fine.
https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecode-array-builder.h
File src/interpreter/bytecode-array-builder.h (right):
https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecode-array-builder.h#newcode82
src/interpreter/bytecode-array-builder.h:82: DCHECK_LE(index_,
kMaxRegisterIndex);
Probably worth having a lower bounds DCHECK too.
https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):
https://codereview.chromium.org/1283313003/diff/40001/src/interpreter/bytecodes.h#newcode113
src/interpreter/bytecodes.h:113: std::ostream& operator<<(std::ostream&
os, const OperandType& operand_type);
Couldn't spot where this is used (?).
https://codereview.chromium.org/1283313003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
