I'm not sure the level of indirection is helping us here.
http://codereview.chromium.org/575022/diff/8001/9008 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/575022/diff/8001/9008#newcode800 src/arm/ic-arm.cc:800: void StoreIC::GenerateExtendStorage(MacroAssembler* masm) { Is there a reason to keep this function? http://codereview.chromium.org/575022/diff/8001/9007 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/575022/diff/8001/9007#newcode294 src/arm/stub-cache-arm.cc:294: if (!receiver_reg.is(r3)) { __ push(receiver_reg); __ mov(r2, Operand(Handle<Map>(transition))); __ stm(db_w, sp, r2.bit() | r0.bit()); __ TailCallRuntime( ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)),3, 1); http://codereview.chromium.org/575022/diff/8001/9009 File src/builtins.h (right): http://codereview.chromium.org/575022/diff/8001/9009#newcode72 src/builtins.h:72: V(StoreIC_ExtendStorage, BUILTIN, UNINITIALIZED) \ Is there a reason to keep this builtin? http://codereview.chromium.org/575022/diff/8001/9001 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/575022/diff/8001/9001#newcode640 src/ia32/stub-cache-ia32.cc:640: if (!receiver_reg.is(edx)) { __ pop(scratch); // Return address. __ push(receiver_reg); __ push(Immediate(Handle<Map>(transition))); __ push(eax); __ push(scratch); __ TailCallRuntime( ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3, 1); http://codereview.chromium.org/575022 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
