Reviewers: Yang, Jarin,
Message:
Created Revert of [runtime] Remove useless IN builtin.
Description:
Revert of [runtime] Remove useless IN builtin. (patchset #2 id:20001 of
https://codereview.chromium.org/1295433002/ )
Reason for revert:
Breaks win32 nosnap
Original issue's description:
[runtime] Remove useless IN builtin.
Similar to DELETE, the IN builtin is just a thin wrapper for %HasElement
and %HasProperty anyway, and cannot be optimized, plus it had a weird
special fast case (which also involved at least one LOAD_IC plus some
intrinsic magic).
[email protected],[email protected]
Committed: https://crrev.com/72d60a1e80e81e2e68ca402665e2acbc46c5e471
Cr-Commit-Position: refs/heads/master@{#30154}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Please review this at https://codereview.chromium.org/1288923002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+282, -41 lines):
M src/builtins.h
M src/compiler/js-generic-lowering.cc
M src/compiler/js-intrinsic-lowering.h
M src/compiler/js-intrinsic-lowering.cc
M src/compiler/typer.cc
M src/full-codegen/arm/full-codegen-arm.cc
M src/full-codegen/arm64/full-codegen-arm64.cc
M src/full-codegen/full-codegen.h
M src/full-codegen/ia32/full-codegen-ia32.cc
M src/full-codegen/mips/full-codegen-mips.cc
M src/full-codegen/mips64/full-codegen-mips64.cc
M src/full-codegen/ppc/full-codegen-ppc.cc
M src/full-codegen/x64/full-codegen-x64.cc
M src/full-codegen/x87/full-codegen-x87.cc
M src/hydrogen.cc
M src/runtime.js
M src/runtime/runtime.h
M src/runtime/runtime-numbers.cc
M src/runtime/runtime-object.cc
M test/cctest/compiler/test-run-inlining.cc
M test/cctest/compiler/test-run-intrinsics.cc
M test/cctest/test-api.cc
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
