Reviewers: jochen (ooo),
Message:
Please have a look.
- Breakage on v8_linux64_avx2_rel looks unrelated.
- The 2nd patch set is there to ensure I'm try-bot testing it on all
platforms.
Actually enabling on all platforms should be a 2nd Cl, though.
Description:
Rework startup-data-util.
- Make the API look like v8::V8::InitializeICU.
(That is: A static method call, not an object to be created on the stack.)
- Fix path separator on Windows, by calling base::OS::isPathSeparator.
- Move into API, so that it can be called by hello-world & friends.
- Actually call it from hello-world and friends.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/1292053002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+127, -118 lines):
M BUILD.gn
M build/standalone.gypi
M include/v8.h
M samples/hello-world.cc
M samples/process.cc
M samples/shell.cc
M src/api.cc
M src/d8.cc
M src/d8.gyp
M src/startup-data-util.h
M src/startup-data-util.cc
M test/cctest/cctest.cc
M test/cctest/cctest.gyp
M test/unittests/run-all-unittests.cc
M test/unittests/unittests.gyp
M tools/gyp/v8.gyp
M tools/parser-shell.cc
M tools/parser-shell.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
